Update PyJWT to 2.3.0 #138
Conversation
sondrelg
left a comment
sondrelg
left a comment
There was a problem hiding this comment.
I think it's important to note the difference in versioning for the requirements.txt and the setup.py. The first dictates what should be installed when running this project locally, the second specifies which versions of dependencies are compatible with this package.
| # http://pypi.python.org/pypi/setuptools | ||
|
|
||
| REQUIRES = ["urllib3 >= 1.15", "six >= 1.8.0", "certifi >= 14.05.14", "python-dateutil >= 2.5.3", "setuptools >= 21.0.0", "PyJWT>=1.7.1,<2", "cryptography>=2.5", "nose>=1.3.7"] | ||
| REQUIRES = ["urllib3 >= 1.15", "six >= 1.8.0", "certifi >= 14.05.14", "python-dateutil >= 2.5.3", "setuptools >= 21.0.0", "PyJWT==2.3.0", "cryptography>=2.5", "nose>=1.3.7"] |
There was a problem hiding this comment.
This will require users to be on exactly version 2.3.0. I think a better option here is to specify between 2-3.
| REQUIRES = ["urllib3 >= 1.15", "six >= 1.8.0", "certifi >= 14.05.14", "python-dateutil >= 2.5.3", "setuptools >= 21.0.0", "PyJWT==2.3.0", "cryptography>=2.5", "nose>=1.3.7"] | |
| REQUIRES = ["urllib3 >= 1.15", "six >= 1.8.0", "certifi >= 14.05.14", "python-dateutil >= 2.5.3", "setuptools >= 21.0.0", "PyJWT>2,<3", "cryptography>=2.5", "nose>=1.3.7"] |
There was a problem hiding this comment.
Yup, the change on the return type of jwt.encode was introduced in 2.0.0 and it's the only thing that could be considered a breaking change in the scope of this project so I guess it'd be alright to loosen the requirement a little bit.
|
+1, can someone please update this lib? |
5 participants
This way, we can use this client with the latest version of Django Rest Framework