This repository has been archived by the owner on Jan 24, 2025. It is now read-only.
fix: allow code inside playground to contain ticks and backticks #203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rakannimer
commented
Aug 9, 2018
| @@ -18,7 +18,7 @@ | |||
| "clean": "lerna clean", | |||
| "bs": "lerna bootstrap", | |||
| "packages": "run-s packages:*", | |||
| "packages:fix": "lerna run fix", | |||
| "packages:fix": "lerna run fix && echo", | |||
There was a problem hiding this comment.
This is a hack, I had to do it because lint-staged was passing the file names as argument to fix script in packages, and it was breaking them, causing a false error.
There was a problem hiding this comment.
I have felt this pain before 😅
pedronauck
suggested changes
Aug 9, 2018
| const child = strip(removePlayground(code)).trim() | ||
| const child = strip(removePlayground(code)) | ||
| .trim() | ||
| .split(`'`) |
There was a problem hiding this comment.
I think that is better to use replace instead of join and split in this case, no?!
There was a problem hiding this comment.
Yeah, I agree. Thanks for doing the change yourself #205
Cheers !
pedronauck
approved these changes
Aug 9, 2018
pedronauck
added a commit
that referenced
this pull request
Aug 9, 2018
…round * 'dev' of github.com:pedronauck/docz: fix(rehype-docz): allow ticks and backticks inside playground (#203)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #201