Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(fix) Search icon and sidebar top border. #721

Merged
merged 1 commit into from
Mar 26, 2019

Conversation

hastebrot
Copy link
Contributor

@hastebrot hastebrot commented Mar 25, 2019

Description

This should fix the sidebar search icon being tiny. It will allow to customize the sidebar logo component, e.g. to hide the top border line.

Review

  • Check if sidebar search icon is norma size.

Screenshots

Before After
Screenshot 2019-03-26 at 00 10 45 Screenshot 2019-03-26 at 00 11 32
Screenshot 2019-03-26 at 00 12 31 Screenshot 2019-03-26 at 00 13 22

@pedronauck pedronauck changed the base branch from master to dev March 26, 2019 21:07
@pedronauck pedronauck merged commit 59a030b into doczjs:dev Mar 26, 2019
pedronauck added a commit that referenced this pull request Mar 29, 2019
* 'dev' of github.com:pedronauck/docz:
  fix(docz-core): entries not initialized on build (#725)
  fix(docz-theme-default): apply ignore in props parsing (#723)
  chore(docz-theme-default): search icon and sidebar top border. (#721)
  chore(docz-theme-default): export enhance from docz-theme-default (#715)
  fix(docz-theme-default): stop nested ul from rendering flat (#714)
  fix(docz-theme-default): mobile menu following anchor clicks (#713)
@hastebrot
Copy link
Contributor Author

hastebrot commented Mar 30, 2019

Just for reference: With this PR (released in v1.0.0-rc.5) the sidebar top border can be removed via doczrc.js.

import { css } from "styled-components"

export default {
  themeConfig: {
    styles: {
      logo: css`
        &:before {
          height: 0;
        }
      `,
    },
  },
}

Don't know if we might add information that styles.logo exists in the readme. https://github.com/pedronauck/docz/blob/v1.0.0-rc.5/core/docz-theme-default/README.md#default-themeconfig

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants