Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show specific code-annotation when annotations are minimized #2037

Closed
stijndcl opened this issue Jun 4, 2020 · 4 comments
Closed

Show specific code-annotation when annotations are minimized #2037

stijndcl opened this issue Jun 4, 2020 · 4 comments
Labels
feature New feature or request

Comments

@stijndcl
Copy link
Contributor

stijndcl commented Jun 4, 2020

Currently, when code-annotations are minimized, Dodona shows a small dot next to lines that have one. It could be a useful feature to be able to click on these dots to show that specific annotation.

image

@thepieterdc thepieterdc added the feature New feature or request label Jun 4, 2020
@pdawyndt
Copy link
Contributor

pdawyndt commented Jun 4, 2020

Show dots only when "minimized" or always show dots (with functionality to manually show/hide corresponding annotations) and treat buttons on top as show all/show some/hide all?

@stijndcl
Copy link
Contributor Author

stijndcl commented Jun 4, 2020

Show dots only when "minimized" or always show dots (with functionality to manually show/hide corresponding annotations) and treat buttons on top as show all/show some/hide all?

Right now, dots are only shown when annotations are hidden, so this is already the case. My suggestion was to be able to click on a dot to show it's annotation, without having to scroll back up to the top & show all annotations.

The buttons up top would still show/hide all annotations, but the separate dots would become clickable in order to open up/hide the specific annotation that they belong to, without showing/hiding all the others.

@pdawyndt
Copy link
Contributor

pdawyndt commented Jun 4, 2020

I was just taking up your line of tought and expanding the idea. If the dots do not clutter the view when the annotations are displayed, we could as well always show them. With the additional functionality to use them as a toggle for displaying the annotations attached to that line. The idea had already came up in #1852 (sixth bullet).

@bmesuere bmesuere added the student Things summer interns can do label Jun 5, 2020
@thepieterdc thepieterdc removed their assignment Jun 15, 2020
@bmesuere bmesuere removed the student Things summer interns can do label Apr 15, 2021
@bmesuere bmesuere added this to Roadmap Apr 17, 2022
@bmesuere bmesuere moved this to Unplanned in Roadmap Apr 17, 2022
@bmesuere
Copy link
Member

This has been fixed with #4568. Hovering over the squiggly line shows the full annotation.

@github-project-automation github-project-automation bot moved this from Unplanned to Done in Roadmap Oct 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants