Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace our custom fullscreen polyfill by an external one #3593

Merged
merged 2 commits into from
May 3, 2022
Merged

Replace our custom fullscreen polyfill by an external one #3593

merged 2 commits into from
May 3, 2022

Conversation

bmesuere
Copy link
Member

@bmesuere bmesuere commented May 3, 2022 •
edited
Loading

This pull request replaces our custom fullscreen polyfill by fscreen which is recommended on mdn.

Advantages:

  • less than 1kB gzipped
  • has up to date browser support
  • gets rid of a lot of legacy jquery code
  • is imported properly instead of adding it to the global scope

I tested this on naos and everything seems to work.

@bmesuere bmesuere added the deploy mestra Request a deployment on mestra label May 3, 2022
@bmesuere bmesuere mentioned this pull request May 3, 2022
Closed
9 tasks
@bmesuere bmesuere added deploy mestra Request a deployment on mestra and removed deploy mestra Request a deployment on mestra labels May 3, 2022
@bmesuere bmesuere temporarily deployed to mestra May 3, 2022 12:11 Inactive
@bmesuere bmesuere temporarily deployed to naos May 3, 2022 12:14 Inactive
@github-actions github-actions bot removed the deploy mestra Request a deployment on mestra label May 3, 2022
@bmesuere bmesuere marked this pull request as ready for review May 3, 2022 12:18
@bmesuere bmesuere requested review from chvp and a team as code owners May 3, 2022 12:18
@bmesuere bmesuere requested review from jorg-vr and removed request for a team May 3, 2022 12:18
@bmesuere bmesuere merged commit 117b2c7 into develop May 3, 2022
@bmesuere bmesuere deleted the chore/fscreen branch May 3, 2022 12:29
@bmesuere bmesuere added the chore Repository/build/dependency maintenance label May 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jorg-vr jorg-vr jorg-vr approved these changes

@niknetniko niknetniko niknetniko approved these changes

@chvp chvp Awaiting requested review from chvp

Assignees
No one assigned
Labels
chore Repository/build/dependency maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bmesuere @niknetniko @jorg-vr