Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically filter on courses for which you can register when relevant #3902

Merged
merged 8 commits into from
Aug 19, 2022

Conversation

jorg-vr
Copy link
Contributor

@jorg-vr jorg-vr commented Aug 19, 2022

This pull request filters the courses list on courses for which the user can register. It also adds some extra icons to visualize whether you are already registered.

The filter is optional. It it automatically activated when accessing the courses list from the home page. (Either 'more courses' or 'view courses') But it can be disabled through the search options.

image
image

  • test where added

@jorg-vr jorg-vr added the feature New feature or request label Aug 19, 2022
@jorg-vr jorg-vr self-assigned this Aug 19, 2022
@jorg-vr jorg-vr marked this pull request as ready for review August 19, 2022 10:21
@jorg-vr jorg-vr requested a review from a team as a code owner August 19, 2022 10:21
@jorg-vr jorg-vr requested review from bmesuere and niknetniko and removed request for a team August 19, 2022 10:21
@bmesuere bmesuere requested a review from chvp August 19, 2022 11:40
@bmesuere bmesuere temporarily deployed to naos August 19, 2022 11:41 Inactive
Copy link
Member

@bmesuere bmesuere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • On naos, I can only see 5 courses in "all courses" as zeus user
  • Is it possible to only enable it on the all courses page? Right now, even the "my courses" list is empty which is unwanted behaviour.

@jorg-vr jorg-vr requested a review from bmesuere August 19, 2022 13:11
@bmesuere bmesuere temporarily deployed to naos August 19, 2022 13:42 Inactive
@jorg-vr jorg-vr merged commit 6131ff4 into develop Aug 19, 2022
@jorg-vr jorg-vr deleted the feature/filter-on-coures-on-registration branch August 19, 2022 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants