-
-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Course.js: remove jquery and convert to typescript #3921
Conversation
This pull request introduces 2 alerts when merging f52a4b1 into 7cce90f - view on LGTM.com new alerts:
|
This pull request introduces 1 alert when merging 957be15 into 7cce90f - view on LGTM.com new alerts:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A minor nitpick: I think template strings (between backticks) would look cleaner for the selectors where you now have to escape the double quotes, e.g., in type=\"radio\"
.
…low this in eslintrc
I've applied this and also changed the |
This pull request removes jquery code out of
course.js
progress on #3590, closes #3923 .