-
-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show class progress on series homepage cards for teachers #4247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorg-vr
added
the
enhancement
A change that isn't substantial enough to be called a feature
label
Dec 15, 2022
pdawyndt
changed the title
Show class progress on series hompage cards for teachers
Show class progress on series homepage cards for teachers
Dec 15, 2022
jorg-vr
requested review from
bmesuere and
chvp
and removed request for
a team
December 19, 2022 13:20
bmesuere
requested changes
Dec 19, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bmesuere
approved these changes
Dec 20, 2022
1 task
…/show-class-progress-for-teachers
jorg-vr
changed the base branch from
develop
to
enhancement/always-update-activity-status
January 6, 2023 09:31
niknetniko
approved these changes
Jan 9, 2023
Base automatically changed from
enhancement/always-update-activity-status
to
develop
January 10, 2023 09:44
chvp
approved these changes
Jan 10, 2023
bmesuere
added
feature
New feature or request
and removed
enhancement
A change that isn't substantial enough to be called a feature
labels
Jan 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request replaces the users progress by the class progress on the homepage series cards, when the user is an admin of the course.
There is an icon in the top right that should make clear it is a different kind of card for teachers. I also removed the red/green color coding for teachers, as it makes less sense for this usecase.
Part of #2882