Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show class progress on series homepage cards for teachers #4247

Merged
merged 16 commits into from
Jan 11, 2023

Conversation

jorg-vr
Copy link
Contributor

@jorg-vr jorg-vr commented Dec 15, 2022

This pull request replaces the users progress by the class progress on the homepage series cards, when the user is an admin of the course.

There is an icon in the top right that should make clear it is a different kind of card for teachers. I also removed the red/green color coding for teachers, as it makes less sense for this usecase.

image
image
image

  • Tests were added

Part of #2882

@jorg-vr jorg-vr added the enhancement A change that isn't substantial enough to be called a feature label Dec 15, 2022
@jorg-vr jorg-vr self-assigned this Dec 15, 2022
@pdawyndt pdawyndt changed the title Show class progress on series hompage cards for teachers Show class progress on series homepage cards for teachers Dec 15, 2022
@jorg-vr jorg-vr temporarily deployed to naos December 16, 2022 09:10 — with GitHub Actions Inactive
@jorg-vr jorg-vr temporarily deployed to naos December 16, 2022 09:31 — with GitHub Actions Inactive
@jorg-vr jorg-vr temporarily deployed to naos December 16, 2022 13:51 — with GitHub Actions Inactive
@jorg-vr jorg-vr temporarily deployed to naos December 16, 2022 14:02 — with GitHub Actions Inactive
@jorg-vr jorg-vr marked this pull request as ready for review December 19, 2022 13:20
@jorg-vr jorg-vr requested a review from a team as a code owner December 19, 2022 13:20
@jorg-vr jorg-vr requested review from bmesuere and chvp and removed request for a team December 19, 2022 13:20
@bmesuere bmesuere added the deploy mestra Request a deployment on mestra label Dec 19, 2022
@bmesuere bmesuere temporarily deployed to mestra December 19, 2022 13:58 — with GitHub Actions Inactive
@github-actions github-actions bot removed the deploy mestra Request a deployment on mestra label Dec 19, 2022
Copy link
Member

@bmesuere bmesuere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but the teacher icon gets eaten by long series names:
image

@jorg-vr
Copy link
Contributor Author

jorg-vr commented Dec 19, 2022

Fixed:
image

@jorg-vr jorg-vr requested a review from bmesuere December 19, 2022 14:32
@jorg-vr jorg-vr changed the base branch from develop to enhancement/always-update-activity-status January 6, 2023 09:31
Base automatically changed from enhancement/always-update-activity-status to develop January 10, 2023 09:44
@chvp chvp added the deploy mestra Request a deployment on mestra label Jan 10, 2023
@jorg-vr jorg-vr temporarily deployed to naos January 11, 2023 08:10 — with GitHub Actions Inactive
@jorg-vr jorg-vr temporarily deployed to naos January 11, 2023 08:42 — with GitHub Actions Inactive
@jorg-vr jorg-vr merged commit fd3a899 into develop Jan 11, 2023
@jorg-vr jorg-vr deleted the feature/show-class-progress-for-teachers branch January 11, 2023 09:00
@bmesuere bmesuere added feature New feature or request and removed enhancement A change that isn't substantial enough to be called a feature labels Jan 11, 2023
@bmesuere bmesuere removed the deploy mestra Request a deployment on mestra label Jan 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants