Limit the amount of users exposed by the repository admin screen #4382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorg-vr
requested review from
bmesuere and
niknetniko
and removed request for
a team
niknetniko
approved these changes
Feb 3, 2023
bmesuere
requested changes
Feb 4, 2023
There was a problem hiding this comment.
- I think we want a different empty state message when the page is loaded. It now says "Er werden te veel gebruikers gevonden. Gebruik de zoekbalk om de resultaten te filteren." but I didn't do anything yet. Something like "Enter at least x characters to search for users by first or last name" seems appropriate.
- If the list is truncated, "Er werden te veel gebruikers gevonden" seems strange. I would say explicitly that only the first few results are shown. Maybe also something like "Can't find who you're looking for? Try searching on their full name or filter by institution"
- The sort by length seems a bit strange/random on naos. I think we can just sort alphabetically now that we have an institution filter?
bmesuere
approved these changes
Feb 6, 2023
db/schema.rb
Outdated
Comment on lines
107
to
109
| t.index ["series_id", "started", "user_id", "last_submission_id"], name: "index_as_on_series_and_started_and_user_and_last_submission" | ||
| t.index ["series_id"], name: "fk_rails_1bc42c2178" | ||
| t.index ["started", "user_id", "last_submission_id"], name: "index_as_on_started_and_user_and_last_submission" | ||
| t.index ["started", "user_id", "series_id"], name: "index_activity_statuses_on_started_and_user_id_and_series_id" |
There was a problem hiding this comment.
This was probably included by accident?
niknetniko
approved these changes
Feb 6, 2023
Co-authored-by: Bart Mesuere <Bart.Mesuere@UGent.be>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request stops the repository admin sceen from leaking all users.
All users can still be found by typing a specific enough query, but the full list is no longer loaded by default. This is a compromise between usability and privacy.
Results are only returned if at least three characters are used as filter and at most 10 results are shown at any time
Part of #4362