Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't show saved annotations from other users to zeus #5167

Merged
merged 1 commit into from
Nov 17, 2023

Conversation

jorg-vr
Copy link
Contributor

@jorg-vr jorg-vr commented Nov 17, 2023

This pull request removes saved annotations from the results zeus users receive.
This gives zeus users the intended user experience. In case of detecting bugs in this feature they should use impersonate.

  • Tests were added

Closes #5166

@jorg-vr jorg-vr added the bug Something isn't working label Nov 17, 2023
@jorg-vr jorg-vr self-assigned this Nov 17, 2023
@jorg-vr jorg-vr requested a review from a team as a code owner November 17, 2023 13:17
@jorg-vr jorg-vr requested review from niknetniko and chvp and removed request for a team November 17, 2023 13:17
Copy link
Member

@chvp chvp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jorg-vr jorg-vr merged commit 9b2e3fe into main Nov 17, 2023
15 checks passed
@jorg-vr jorg-vr deleted the fix/saved-annotation-scoping branch November 17, 2023 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Saved annotations might not always be correctly filtered
3 participants