Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge contexts across tabs #329

Closed
pdawyndt opened this issue Mar 27, 2023 · 1 comment · Fixed by #437
Closed

Merge contexts across tabs #329

pdawyndt opened this issue Mar 27, 2023 · 1 comment · Fixed by #437
Labels
enhancement New feature or request

Comments

@pdawyndt
Copy link
Contributor

pdawyndt commented Mar 27, 2023

Merged processing of contexts is now restricted to contexts in a single tab. This gives an overhead for exercises with multiple tabs that could be eradicated if contexts could be merged across tabs.

@pdawyndt pdawyndt changed the title Merge all contexts across tabs Merge contexts across tabs Mar 27, 2023
@niknetniko niknetniko added the enhancement New feature or request label Mar 31, 2023
@niknetniko
Copy link
Member

Currently, if compilation fails, we try to compile each "execution unit" individually (this used to be per context, but since we have runs, it is per execution unit). However, with this change, an execution unit is potentially a complete test suite, rendering the fallback compilation mode moot.

Thus, should we try again by compiling each tab separately, or should we compile each context separately? The first is far more efficient, but the second one is "more" correct. A third alternative would be to first try compiling per tab, and then per context. If we want to make things complicated, we could even determine this per tab, e.g:

  1. Try compiling everything together, if this fails:
  2. Try compiling each tab. For each tab, if this fails:
  3. Try compiling per context.

We could thus have a scenario where the first tab is compiled as a unit, after which tab 2 is compiled per context.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants