Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Various improvements #323

Merged
merged 8 commits into from
Mar 20, 2023
Merged

Various improvements #323

merged 8 commits into from
Mar 20, 2023

Conversation

niknetniko
Copy link
Member

  • Remove the timing code, as it is no longer used a lot. In specific cases where we need to see performance information, we can use a profiler.
  • Convert all imports to absolute imports, as recommended by PEP8.
  • Sort (and check the sorting) of imports.
  • Fixes DSL Configuration options at root not passed to evaluator #322
  • Move to Black v23.

github-advanced-security[bot]
github-advanced-security bot found potential problems Mar 20, 2023
View reviewed changes
tested/testsuite.py
Comment on lines +19 to +25
from tested.features import (
NOTHING,
Construct,
FeatureSet,
WithFeatures,
combine_features,
)

Check notice

Code scanning / CodeQL

Cyclic import

Import of module [tested.features](1) begins an import cycle.
tested/languages/config.py
from ..utils import (
from typing import Any, Callable, Dict, List, Mapping, Optional, Set, Tuple, Union

from tested.configs import Bundle

Check notice

Code scanning / CodeQL

Cyclic import

Import of module [tested.configs](1) begins an import cycle.
tested/judge/evaluation.py
from tested.evaluators import get_evaluator
from tested.internationalization import get_i18n_string
from tested.judge.collector import OutputManager, TestcaseCollector
from tested.judge.execution import ContextResult

Check notice

Code scanning / CodeQL

Cyclic import

Import of module [tested.judge.execution](1) begins an import cycle.
tested/judge/execution.py

from tested.configs import Bundle
from tested.dodona import Message, Status
from tested.judge.collector import OutputManager

Check notice

Code scanning / CodeQL

Cyclic import

Import of module [tested.judge.collector](1) begins an import cycle.
tested/serialisation.py
from .features import FeatureSet, combine_features, WithFeatures, Construct
from .utils import get_args, flatten, sorted_no_duplicates
from tested.dodona import ExtendedMessage, Status
from tested.features import Construct, FeatureSet, WithFeatures, combine_features

Check notice

Code scanning / CodeQL

Cyclic import

Import of module [tested.features](1) begins an import cycle.
tested/judge/evaluation.py
)
from tested.evaluators import get_evaluator
from tested.internationalization import get_i18n_string
from tested.judge.collector import OutputManager, TestcaseCollector

Check notice

Code scanning / CodeQL

Cyclic import

Import of module [tested.judge.collector](1) begins an import cycle.
tested/languages/config.py
from tested.configs import Bundle
from tested.datatypes import AdvancedTypes, AllTypes, ExpressionTypes, string_to_type
from tested.dodona import AnnotateCode, ExtendedMessage, Message, Permission, Status
from tested.features import Construct

Check notice

Code scanning / CodeQL

Cyclic import

Import of module [tested.features](1) begins an import cycle.
tested/languages/config.py
from tested.features import Construct
from tested.internationalization import get_i18n_string
from tested.languages.description_generator import DescriptionGenerator
from tested.serialisation import ExceptionValue

Check notice

Code scanning / CodeQL

Cyclic import

Import of module [tested.serialisation](1) begins an import cycle.
tested/languages/config.py
from tested.internationalization import get_i18n_string
from tested.languages.description_generator import DescriptionGenerator
from tested.serialisation import ExceptionValue
from tested.testsuite import Suite

Check notice

Code scanning / CodeQL

Cyclic import

Import of module [tested.testsuite](1) begins an import cycle.
tested/configs.py

from pydantic import BaseModel, root_validator
from pydantic.dataclasses import dataclass

from .testsuite import Suite, ExecutionMode
from .utils import smart_close, consume_shebang, get_identifier
from tested.testsuite import ExecutionMode, Suite

Check notice

Code scanning / CodeQL

Cyclic import

Import of module [tested.testsuite](1) begins an import cycle.
@niknetniko niknetniko merged commit 4da8864 into master Mar 20, 2023
@niknetniko niknetniko deleted the chore/imports branch March 20, 2023 13:19
niknetniko added a commit that referenced this pull request Nov 22, 2023
@niknetniko
Add internal profiler
10123a1 
Add a simplified version of #252.

These were removed in #323, as most issues could be found locally using
a profiler. However, recently, discrepancies have appeared,
necessitating the return of this module.
niknetniko added a commit that referenced this pull request Nov 22, 2023
@niknetniko
Add internal profiler
89d8bea 
Add a simplified version of #252.

These were removed in #323, as most issues could be found locally using
a profiler. However, recently, discrepancies have appeared,
necessitating the return of this module.
@niknetniko niknetniko mentioned this pull request Nov 22, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DSL Configuration options at root not passed to evaluator
1 participant
@niknetniko