Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visitors for TypeScript #566

Closed
wants to merge 3 commits into from
Closed

Visitors for TypeScript #566

wants to merge 3 commits into from

Conversation

BrentBlanckaert
Copy link
Collaborator

Making a visitors that can be used for the generation.py files. This is the implementation for TypeScript.

@BrentBlanckaert BrentBlanckaert changed the title init new branch Visitors for TypeScript Nov 28, 2024
@BrentBlanckaert BrentBlanckaert self-assigned this Nov 28, 2024
@@ -21,6 +21,7 @@
import logging
import math
import operator
from abc import abstractmethod

Check notice

Code scanning / CodeQL

Unused import Note test

Import of 'abstractmethod' is not used.
Comment on lines +156 to +162
# class Statement(WithFeatures, WithFunctions):
# """
# Base class for representing Statements which represent Expressions and Assignments
# """
#
# def accept(self, visitor: "ConvertStatementVisitor") -> None:
# visitor.visit(self)

Check notice

Code scanning / CodeQL

Commented-out code Note test

This comment appears to contain commented-out code.
@@ -11,7 +11,7 @@
from typing import get_args as typing_get_args

if TYPE_CHECKING:
from tested.serialisation import Assignment
from tested.serialisation import AbstractAssignment

Check failure

Code scanning / CodeQL

Module-level cyclic import Error test

'AbstractAssignment' may not be defined if module
tested.serialisation
is imported before module
tested.utils
, as the
definition
of AbstractAssignment occurs after the cyclic
import
of tested.utils.
'AbstractAssignment' may not be defined if module
tested.serialisation
is imported before module
tested.utils
, as the
definition
of AbstractAssignment occurs after the cyclic
import
of tested.utils.
@BrentBlanckaert
Copy link
Collaborator Author

BrentBlanckaert commented Dec 3, 2024

Will not fix for now. See issue #564 for more info.

@BrentBlanckaert BrentBlanckaert deleted the add_visitor_ts branch December 7, 2024 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant