Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

is there a reason of using jquery.xml2json? #83

Closed
wood1986 opened this issue Jul 21, 2015 · 2 comments
Closed

is there a reason of using jquery.xml2json? #83

wood1986 opened this issue Jul 21, 2015 · 2 comments

Comments

@wood1986
Copy link

Is there a reason of using jquery.xml2json? jquery.xml2json blocks from using latest jquery because of "dependencies" : { "jquery": "1.11" } in xtreemrage/jquery.xml2json/bower.json

Would mind changing to use sparkbuzz/jQuery-xml2json?
@doedje
Copy link
Owner

doedje commented Sep 2, 2015

sorry for late reply, summer holidayzzzzzzz..... But I wil look into that...

@doedje
Copy link
Owner

doedje commented Sep 3, 2015

The jquery.xml2json plugin is only used for the SOAPResponse.toJSON() function. Changing it to sparkbuzz would definitely break other peoples code. But the fyneworks/xtreemrage version is quite crappy. It does fine with simple soap responses but fails massively at other XMLs I came across...

I think the best thing would be to drop the dependency altogether and add some additional info regarding the use of SOAPResponse in combination with a 3rd party jquery plugin like the sparkbuzz version in the README.......

@wood1986 wood1986 closed this as completed Sep 3, 2015
doedje added a commit that referenced this issue Sep 4, 2015
@doedje
removed the dependency on jquery.xml2json from bower.json as discusse…
cbe3f7e 
…d in #83
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@doedje @wood1986