Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a new flag for enabling WebSocket which should be false by default #151

Closed
DarianShawn opened this issue Aug 30, 2022 · 0 comments · Fixed by #152
Closed

Add a new flag for enabling WebSocket which should be false by default #151

DarianShawn opened this issue Aug 30, 2022 · 0 comments · Fixed by #152
Assignees
Labels
feature-wanted We want this feature please
Milestone

Comments

@DarianShawn
Copy link
Collaborator

Default enabled websocket would eat up much memory.

It is better to provide a flag enable-ws to enable websocket service only when it is necessary.

@DarianShawn DarianShawn self-assigned this Aug 30, 2022
@DarianShawn DarianShawn linked a pull request Aug 30, 2022 that will close this issue
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-wanted We want this feature please
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant