Add enable-ws flag in server command #152
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The WebSocket enpoint was enabled by default, it would consumes too many connections of the RPC node when exposed in the Internet.
This PR adds the
enable-ws
flag to the server command, and disable the WebSocket endpoint by default.Changes include
Checklist
Testing
Manual tests
dev
mode server, usingenable-ws
flag or without it.We should not be able to connect to
ws://localhost:8545/ws
endpoint whenenable-ws
flag not set. And vice versa.Documentation update
Would update the documentation when new released done.