Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix delete workflow action not working #120

Merged
merged 1 commit into from
Sep 1, 2022

Conversation

DarianShawn
Copy link
Collaborator

Description

This PR uses another workflow to cron trigger deleting outdated actions, and it skips tag actions, which is more reasonable for long term tracing.

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

@DarianShawn DarianShawn self-assigned this Jul 27, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #120 (288b7ee) into dev (de185af) will increase coverage by 0.07%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##              dev     #120      +/-   ##
==========================================
+ Coverage   51.53%   51.61%   +0.07%     
==========================================
  Files         112      112              
  Lines       16465    16465              
==========================================
+ Hits         8485     8498      +13     
+ Misses       7247     7236      -11     
+ Partials      733      731       -2     
Impacted Files Coverage Δ
protocol/sync_peer.go 70.00% <0.00%> (+1.00%) ⬆️
network/server_discovery.go 81.52% <0.00%> (+7.64%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us.

@DarianShawn
Copy link
Collaborator Author

@abrahamcruise321 Hi, abra.
Would you pay attention to this fix?
The workflow action is eating our Github storage.

Copy link
Collaborator

@abrahamcruise321 abrahamcruise321 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

@abrahamcruise321 abrahamcruise321 merged commit 3348150 into dev Sep 1, 2022
@abrahamcruise321 abrahamcruise321 deleted the fix/delete-workflow-not-working branch September 1, 2022 06:49
@github-actions github-actions bot locked and limited conversation to collaborators Sep 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants