Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add limitation to jsonrpc batch query and block range #145

Merged

Conversation

DarianShawn
Copy link
Collaborator

Description

The PR merges some significant improvements of jsonrpc from upstream 0xPolygon Edge repo, together with the graphql block limitation, and providing two new server command flag for query limitation.

Default rpc batch query limited to 1, block range limited to 100, which can be changed, or disabled (by setting to zero).

The merging PR include 570, 638, 641, 682.

Associated commit SHA:

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

@DarianShawn DarianShawn added feature New update to Dogechain bug fix Functionality that fixes a bug labels Aug 24, 2022
@DarianShawn DarianShawn self-assigned this Aug 24, 2022
Copy link
Collaborator

@abrahamcruise321 abrahamcruise321 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice job.

@abrahamcruise321 abrahamcruise321 merged commit 5fff9a8 into dev Aug 25, 2022
@abrahamcruise321 abrahamcruise321 deleted the feature/optimize-jsonrpc-performance-from-upstream branch August 25, 2022 02:34
@github-actions github-actions bot locked and limited conversation to collaborators Aug 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug fix Functionality that fixes a bug feature New update to Dogechain
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants