Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve memory creep when copy header #154

Merged
merged 3 commits into from
Sep 1, 2022
Merged

Resolve memory creep when copy header #154

merged 3 commits into from
Sep 1, 2022

Conversation

DarianShawn
Copy link
Collaborator

Description

This PR resolves a steady memory creep that has been noted in the Header.Copy() method.

It's merging from 0xPolygon Edge project, the PR reference: 668

zivkovicmilos had tested in pprof.

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

@DarianShawn DarianShawn added the bug fix Functionality that fixes a bug label Aug 31, 2022
@DarianShawn DarianShawn added this to the Release 1.2.0 milestone Aug 31, 2022
@DarianShawn DarianShawn self-assigned this Aug 31, 2022
abrahamcruise321
abrahamcruise321 approved these changes Sep 1, 2022
View reviewed changes
Copy link
Collaborator

@abrahamcruise321 abrahamcruise321 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@abrahamcruise321 abrahamcruise321 merged commit 96ffb10 into dev Sep 1, 2022
@abrahamcruise321 abrahamcruise321 deleted the fix/header-shallow-copy branch September 1, 2022 03:29
@github-actions github-actions bot locked and limited conversation to collaborators Sep 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@abrahamcruise321 abrahamcruise321 abrahamcruise321 approved these changes

Assignees

@DarianShawn DarianShawn

Labels
bug fix Functionality that fixes a bug
Projects
None yet
Milestone
Release 1.1.3
Development

Successfully merging this pull request may close these issues.
2 participants
@DarianShawn @abrahamcruise321