Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add bridge contract options in TestServer #16

Merged
merged 1 commit into from
Apr 25, 2022
Merged

Add bridge contract options in TestServer #16

merged 1 commit into from
Apr 25, 2022

Conversation

DarianShawn
Copy link
Collaborator

Description

To separate different test network in parallel test cases, we should add more different options like chainID, account, storage, etc.

This PR would bring up the difference by default, which would separate our test cases network transparently.

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

@DarianShawn
Add bridge contract options in TestServer
9bc14cb 
To separate different test network in parallel test cases, we should add more different options
like chainID, account, storage, etc.
@DarianShawn DarianShawn self-assigned this Apr 24, 2022
abrahamcruise321
abrahamcruise321 approved these changes Apr 25, 2022
View reviewed changes
Copy link
Collaborator

@abrahamcruise321 abrahamcruise321 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@abrahamcruise321 abrahamcruise321 merged commit 0cc878e into dev Apr 25, 2022
@abrahamcruise321 abrahamcruise321 deleted the fix/more-config-for-testserver-network-separation branch April 25, 2022 02:25
@github-actions github-actions bot locked and limited conversation to collaborators Apr 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@abrahamcruise321 abrahamcruise321 abrahamcruise321 approved these changes

Assignees

@DarianShawn DarianShawn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DarianShawn @abrahamcruise321