Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: e2e defunct process #192

Merged
merged 10 commits into from
Sep 22, 2022

Conversation

0xcb9ff9
Copy link

@0xcb9ff9 0xcb9ff9 commented Sep 22, 2022

Description

  • fix e2e test created defunct process
  • Unix environment kill process group
  • fix protocol/testing.go data directory path empty (use t.TempDir() temp directory)
  • fix mockStore.GetReceiptsByHash concurrent error
  • never use the same port

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

@0xcb9ff9 0xcb9ff9 self-assigned this Sep 22, 2022
@0xcb9ff9 0xcb9ff9 marked this pull request as ready for review September 22, 2022 07:58
@codecov-commenter
Copy link

Codecov Report

Merging #192 (65e8fc7) into dev (ec87ccd) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 65e8fc7 differs from pull request most recent head ff2c024. Consider uploading reports for the commit ff2c024 to get more accurate results

@@           Coverage Diff           @@
##              dev     #192   +/-   ##
=======================================
  Coverage   51.43%   51.43%           
=======================================
  Files         114      114           
  Lines       16948    16950    +2     
=======================================
+ Hits         8717     8719    +2     
  Misses       7491     7491           
  Partials      740      740           
Impacted Files Coverage Δ
protocol/testing.go 83.54% <100.00%> (+0.14%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Makefile Show resolved Hide resolved
e2e/framework/cmd.go Outdated Show resolved Hide resolved
Copy link
Collaborator

@DarianShawn DarianShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, man. 💯
It fixes the test probabilistic failure that we had long missed.

A minor correction would make it better.

@0xcb9ff9 0xcb9ff9 added the bug fix Functionality that fixes a bug label Sep 22, 2022
@DarianShawn DarianShawn merged commit 85538b4 into dogechain-lab:dev Sep 22, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Sep 22, 2022
@0xcb9ff9 0xcb9ff9 deleted the fix/e2e_defunct_process branch October 18, 2022 07:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug fix Functionality that fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants