Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring leveldb code #193

Merged
merged 1 commit into from
Sep 24, 2022
Merged

Refactoring leveldb code #193

merged 1 commit into from
Sep 24, 2022

Conversation

0xcb9ff9
Copy link

Description

refactoring blocakchain storage interface

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Breaking changes

Please complete this section if any breaking changes have been made, otherwise delete it

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

@0xcb9ff9 0xcb9ff9 added the feature New update to Dogechain label Sep 22, 2022
@0xcb9ff9 0xcb9ff9 added this to the Release 1.1.4 milestone Sep 22, 2022
@0xcb9ff9 0xcb9ff9 self-assigned this Sep 22, 2022
@DarianShawn
Copy link
Collaborator

@0xcb9ff9
I would suggest adding a manual test, to ensure the enhancement is backward compatible.
The test could be deployed in our test network, or some private network you created.

@0xcb9ff9
Copy link
Author

@DarianShawn the branch need rebase, I will try run full node to sync mainnet

@0xcb9ff9 0xcb9ff9 force-pushed the feature/reuion-leveldb-interface branch 2 times, most recently from e1bb99d to 0e949b7 Compare September 23, 2022 02:38
@0xcb9ff9 0xcb9ff9 force-pushed the feature/reuion-leveldb-interface branch from 0e949b7 to a60948b Compare September 23, 2022 09:46
DarianShawn
DarianShawn approved these changes Sep 24, 2022
View reviewed changes
Copy link
Collaborator

@DarianShawn DarianShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job. 💯

Merge it once the long-running validation passed.

@DarianShawn DarianShawn merged commit 1f61163 into dev Sep 24, 2022
@DarianShawn DarianShawn deleted the feature/reuion-leveldb-interface branch September 24, 2022 07:07
@github-actions github-actions bot locked and limited conversation to collaborators Sep 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@DarianShawn DarianShawn DarianShawn approved these changes

@abrahamcruise321 abrahamcruise321 Awaiting requested review from abrahamcruise321 abrahamcruise321 is a code owner

Assignees

@0xcb9ff9 0xcb9ff9

Labels
feature New update to Dogechain
Projects
None yet
Milestone
Release 1.1.4
Development

Successfully merging this pull request may close these issues.
2 participants
@0xcb9ff9 @DarianShawn