Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cmd] Set server command seal flag default to false #196

Merged
merged 2 commits into from
Sep 23, 2022

Conversation

DarianShawn
Copy link
Collaborator

Description

The default value of seal flag was set to true, which means that a full node has to handle gossip transactions even they don't need it. Then massive transactions flood the node's txpool, and they'll print out huge amount insufficient funds logs .

This PR sets the flag default to false, makes it quiet and restoring calm.

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

Documentation update

Will upgrade the documentation once it merged.

Additional comments

Associated issue: #156

@DarianShawn DarianShawn added the bug fix Functionality that fixes a bug label Sep 23, 2022
@DarianShawn DarianShawn added this to the Release 1.1.4 milestone Sep 23, 2022
@DarianShawn DarianShawn self-assigned this Sep 23, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #196 (564da07) into dev (1225fcc) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##              dev     #196      +/-   ##
==========================================
+ Coverage   51.39%   51.41%   +0.01%     
==========================================
  Files         114      114              
  Lines       16962    16968       +6     
==========================================
+ Hits         8718     8724       +6     
  Misses       7504     7504              
  Partials      740      740              
Impacted Files Coverage Δ
txpool/txpool.go 69.18% <100.00%> (+0.34%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link

@0xcb9ff9 0xcb9ff9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DarianShawn DarianShawn merged commit d568b65 into dev Sep 23, 2022
@DarianShawn DarianShawn deleted the fix/seal-by-default branch September 23, 2022 09:16
@github-actions github-actions bot locked and limited conversation to collaborators Sep 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug fix Functionality that fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants