Fix: routing table size use MaxPeers config #200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xcb9ff9
requested review from
DarianShawn and
abrahamcruise321
as code owners
Codecov Report
@@ Coverage Diff @@
## dev #200 +/- ##
==========================================
- Coverage 51.21% 50.28% -0.94%
==========================================
Files 117 117
Lines 17525 18341 +816
==========================================
+ Hits 8975 9222 +247
- Misses 7789 8321 +532
- Partials 761 798 +37
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
DarianShawn
reviewed
Sep 29, 2022
DarianShawn
reviewed
Sep 29, 2022
DarianShawn
reviewed
Sep 29, 2022
DarianShawn
requested changes
Sep 29, 2022
0xcb9ff9
force-pushed
the
fix/route_table_size
branch
from
a24523f to
df3b9d4
Compare
DarianShawn
approved these changes
Nov 21, 2022
There was a problem hiding this comment.
Good job.
Well, it seems like I made some mistakes with the bucket size concept.
The TryAddPeer would fail when bucket full.
It is horrible when it was connected by overwhelming peers, and node didn't even notice it.
@abrahamcruise321 Some more suggestions?
|
My node is currently out of sync. When is the new version expected to be released? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Error logs:
network/server_discovery.go#L199 use fixed value
network/server_discovery.go#L211 add peer to dial queue from callback
In extreme cases, each peer will allocate a bucket, and cannot actively initiate a connection to a new peer when the capacity is insufficient
Changes include
Checklist
Testing