Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[network] increase pubsub message buffers #210

Merged
merged 1 commit into from
Oct 18, 2022
Merged

[network] increase pubsub message buffers #210

merged 1 commit into from
Oct 18, 2022

Conversation

0xcb9ff9
Copy link

@0xcb9ff9 0xcb9ff9 commented Oct 17, 2022 •
edited
Loading

Description

  • increase gossip topic subscribe worker buffer size
  • increase libp2p message validate buffer size

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

Manual tests

  • Set up a four-node dogechain private network.
  • Use the tool to send transactions (1000/s)

@0xcb9ff9 0xcb9ff9 added the bug fix Functionality that fixes a bug label Oct 17, 2022
@0xcb9ff9 0xcb9ff9 requested a review from DarianShawn as a code owner October 17, 2022 03:52
@0xcb9ff9 0xcb9ff9 self-assigned this Oct 17, 2022
@0xcb9ff9 0xcb9ff9 changed the title WIP: [network] parameter adjustment [network] parameter adjustment Oct 18, 2022
@0xcb9ff9 0xcb9ff9 changed the title [network] parameter adjustment [network] gossip topic subscribe congest parameter adjustment Oct 18, 2022
@0xcb9ff9 0xcb9ff9 changed the title [network] gossip topic subscribe congest parameter adjustment [network] increase pubsub message buffers Oct 18, 2022
DarianShawn
DarianShawn approved these changes Oct 18, 2022
View reviewed changes
Copy link
Collaborator

@DarianShawn DarianShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You convinced me.
The pubsub buffer should be increased to hold messages from more than one topic.

@DarianShawn DarianShawn merged commit 3de8977 into dogechain-lab:dev Oct 18, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Oct 18, 2022
@0xcb9ff9 0xcb9ff9 deleted the fix/subscribe_congest branch October 21, 2022 10:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@DarianShawn DarianShawn DarianShawn approved these changes

@abrahamcruise321 abrahamcruise321 Awaiting requested review from abrahamcruise321 abrahamcruise321 is a code owner

Assignees

@0xcb9ff9 0xcb9ff9

Labels
bug fix Functionality that fixes a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@0xcb9ff9 @DarianShawn