Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[lint] Ease nolint comment #221

Merged
merged 2 commits into from
Oct 24, 2022
Merged

[lint] Ease nolint comment #221

merged 2 commits into from
Oct 24, 2022

Conversation

DarianShawn
Copy link
Collaborator

Description

The PR adds more lint rules to reduce annoying lint check on test files.

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

@DarianShawn DarianShawn self-assigned this Oct 21, 2022
abrahamcruise321
abrahamcruise321 approved these changes Oct 24, 2022
View reviewed changes
Copy link
Collaborator

@abrahamcruise321 abrahamcruise321 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

@abrahamcruise321 abrahamcruise321 merged commit 23e72e9 into hardfork/pos Oct 24, 2022
@abrahamcruise321 abrahamcruise321 deleted the ease-nolint-comment branch October 24, 2022 07:07
@github-actions github-actions bot locked and limited conversation to collaborators Oct 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@abrahamcruise321 abrahamcruise321 abrahamcruise321 approved these changes

@0xcb9ff9 0xcb9ff9 Awaiting requested review from 0xcb9ff9

Assignees

@DarianShawn DarianShawn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DarianShawn @abrahamcruise321