Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Separate workflows to make it more runnable #222

Merged
merged 9 commits into from
Oct 24, 2022

Conversation

DarianShawn
Copy link
Collaborator

@DarianShawn DarianShawn commented Oct 21, 2022

Description

The main workflows are huge and hard to maintain. This PR separates the main workflows, so as to KISS.

Each workflow has its own trigger conditions.
Build, Lint, Test should be triggered every time there is a push.
E2E tests takes minutes to passed, so we separate it from Test workflow, and only trigger when Pull Request is created (or modified). Besides, the main and dev push events would also trigger e2e tests workflow.

The PR is highly inspired by Polygon Edge PR 765

Changes include

  • New feature (non-breaking change that adds functionality)

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer

Testing

  • I have tested this code with the official test suite

Copy link
Collaborator

@abrahamcruise321 abrahamcruise321 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

@abrahamcruise321 abrahamcruise321 merged commit 999ba6f into dev Oct 24, 2022
@abrahamcruise321 abrahamcruise321 deleted the seperate-workflows branch October 24, 2022 07:07
@github-actions github-actions bot locked and limited conversation to collaborators Oct 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants