Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ethpoint GasPrice() return default 50 Gwei. #23

Merged
merged 1 commit into from
Apr 26, 2022
Merged

ethpoint GasPrice() return default 50 Gwei. #23

merged 1 commit into from
Apr 26, 2022

Conversation

abrahamcruise321
Copy link
Collaborator

@abrahamcruise321 abrahamcruise321 commented Apr 26, 2022 •
edited
Loading

Description

if avgGasPrice less l
GasPrice() check avgGasPrice, if avgGasPrice less than the default 50 GWei, then return 50 GWei.
In order keep gas price no less than 50 GWei.

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Breaking changes

Please complete this section if any breaking changes have been made, otherwise delete it

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

@abrahamcruise321 abrahamcruise321 added the feature New update to Dogechain label Apr 26, 2022
@abrahamcruise321 abrahamcruise321 self-assigned this Apr 26, 2022
@abrahamcruise321 abrahamcruise321 linked an issue Apr 26, 2022 that may be closed by this pull request
ethpoint GasPrice() return default 50 Gwei. #22
Closed
DarianShawn
DarianShawn approved these changes Apr 26, 2022
View reviewed changes
Copy link
Collaborator

@DarianShawn DarianShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Better to upgrade the documentation of community RPC endpoints with its minimum GasLimit.

@abrahamcruise321 abrahamcruise321 merged commit e06eaaf into dev Apr 26, 2022
@abrahamcruise321 abrahamcruise321 deleted the 22-ethpoint-gasprice branch April 26, 2022 06:48
@github-actions github-actions bot locked and limited conversation to collaborators Apr 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@DarianShawn DarianShawn DarianShawn approved these changes

Assignees

@abrahamcruise321 abrahamcruise321

Labels
feature New update to Dogechain
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ethpoint GasPrice() return default 50 Gwei.
2 participants
@abrahamcruise321 @DarianShawn