Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[blockchain] Remove unused storage snapshot functions #230

Merged
merged 1 commit into from
Oct 31, 2022
Merged

[blockchain] Remove unused storage snapshot functions #230

merged 1 commit into from
Oct 31, 2022

Conversation

DarianShawn
Copy link
Collaborator

Description

This PR removes the Snapshot functions from the storage which have been long deprecated.

The PR is merging from PolygonEdge PR 830

Testing

  • I have tested this code with the official test suite

@DarianShawn DarianShawn self-assigned this Oct 28, 2022
@DarianShawn DarianShawn requested a review from 0xcb9ff9 as a code owner October 28, 2022 03:17
abrahamcruise321
abrahamcruise321 approved these changes Oct 31, 2022
View reviewed changes
Copy link
Collaborator

@abrahamcruise321 abrahamcruise321 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@abrahamcruise321 abrahamcruise321 merged commit ee8dd5e into dev Oct 31, 2022
@abrahamcruise321 abrahamcruise321 deleted the remove-unused-stoage-snapshot branch October 31, 2022 08:02
@github-actions github-actions bot locked and limited conversation to collaborators Oct 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@abrahamcruise321 abrahamcruise321 abrahamcruise321 approved these changes

@0xcb9ff9 0xcb9ff9 Awaiting requested review from 0xcb9ff9 0xcb9ff9 is a code owner

Assignees

@DarianShawn DarianShawn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DarianShawn @abrahamcruise321