Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ibft] Ignore ibft message when node is not a validator #231

Merged
merged 3 commits into from
Oct 31, 2022

Conversation

DarianShawn
Copy link
Collaborator

Description

Non-validators don't need to parse any IBFT messages, even if the server seal flag set.
And validators should ignore messages from those non-validators.

The PR fixes the bug.

Changes include

  • Bugfix (non-breaking change that solves an issue)

Testing

  • I have tested this code with the official test suite

@DarianShawn DarianShawn added the bug fix Functionality that fixes a bug label Oct 31, 2022
@DarianShawn DarianShawn added this to the Release 1.2.0 milestone Oct 31, 2022
@DarianShawn DarianShawn self-assigned this Oct 31, 2022
Copy link
Collaborator

@abrahamcruise321 abrahamcruise321 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@abrahamcruise321 abrahamcruise321 merged commit d3d7437 into hardfork/pos Oct 31, 2022
@abrahamcruise321 abrahamcruise321 deleted the fix-ibft-message-validation branch October 31, 2022 08:00
@github-actions github-actions bot locked and limited conversation to collaborators Oct 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug fix Functionality that fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants