Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove assets of init ValidatorSet #24

Merged
merged 1 commit into from
Apr 26, 2022
Merged

Remove assets of init ValidatorSet #24

merged 1 commit into from
Apr 26, 2022

Conversation

DarianShawn
Copy link
Collaborator

Description

The init Validators should not have any assets, including wDoge and DC.
Once it has any assets, the deployer could get profit from it.
What if the deployer is a bad guy? The network economy will crash instantly and cannot be recovered.

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Breaking changes

New genesis file, needs new network deployment.

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

@DarianShawn DarianShawn added the hotfix Major bug fix that should be merged ASAP label Apr 26, 2022
@DarianShawn DarianShawn self-assigned this Apr 26, 2022
abrahamcruise321
abrahamcruise321 approved these changes Apr 26, 2022
View reviewed changes
Copy link
Collaborator

@abrahamcruise321 abrahamcruise321 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@abrahamcruise321 abrahamcruise321 merged commit 874d532 into dev Apr 26, 2022
@abrahamcruise321 abrahamcruise321 deleted the fix/remove-assets-of-init-validatorset branch April 26, 2022 11:05
@github-actions github-actions bot locked and limited conversation to collaborators Apr 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@abrahamcruise321 abrahamcruise321 abrahamcruise321 approved these changes

Assignees

@DarianShawn DarianShawn

Labels
hotfix Major bug fix that should be merged ASAP
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DarianShawn @abrahamcruise321