[ibft] merge back patch 1.1.3 #251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DarianShawn
requested review from
abrahamcruise321 and
0xcb9ff9
as code owners
Some project created a lot of spam transactions and consumed all the gas in the block, which makes the whole network junk and hard to sync due to its heavy I/O consuming. The PR fixed it by banishing all transactions called to some exhausting contracts, and mark a contract once the execution time exceeds a block time. Besides, we create a new option in `IBFT` consensus to enable/disable banishing. Any validators could decide whether tolerating these I/O consuming transactions or not. - [x] Hotfix (change that solves an urgent issue, and requires immediate attention) - [x] I have tested this code with the official test suite
DarianShawn
force-pushed
the
patch-1.1.3
branch
from
3ae56eb to
f3ea1a8
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The PR merges the already running banish mechanism to base branch. Besides, build block should not keep on going, when there is timeout for broadcasting.
Changes include
Testing