-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] merge state update to single transaction #258
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #258 +/- ##
==========================================
- Coverage 51.21% 48.41% -2.80%
==========================================
Files 117 122 +5
Lines 17525 18820 +1295
==========================================
+ Hits 8975 9112 +137
- Misses 7789 8935 +1146
- Partials 761 773 +12
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
@0xcb9ff9 It's a little flawed whether there are more e2e (end-to-end) test cases on transaction recovery in case of a crash than manual testing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some confusing issues to solve.
e7a1f3c
to
2c9d7fd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work.
A little more crafting would make it even better.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here are some suggestions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work. 🙌
Only one last thing: a unit test in protocol failed which shouldn't?
e04dec0
to
1e047fd
Compare
Description
all trie state update merge in single exclusive transaction
Changes include
Testing
Manual tests
environment:
Test 1:
Test 2: