Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[prometheus] fix metric name #264

Merged
merged 1 commit into from
Nov 24, 2022
Merged

[prometheus] fix metric name #264

merged 1 commit into from
Nov 24, 2022

Conversation

0xcb9ff9
Copy link

@0xcb9ff9 0xcb9ff9 commented Nov 24, 2022 •
edited by DarianShawn
Loading

Description

prometheus metric name duplicate

Changes include

  • Bugfix (non-breaking change that solves an issue)

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

Manual tests

run dogechain server --prometheus 0.0.0.0:9090

@0xcb9ff9 0xcb9ff9 added the bug fix Functionality that fixes a bug label Nov 24, 2022
@0xcb9ff9 0xcb9ff9 self-assigned this Nov 24, 2022
DarianShawn
DarianShawn approved these changes Nov 24, 2022
View reviewed changes
Copy link
Collaborator

@DarianShawn DarianShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the timely repair.

@DarianShawn DarianShawn merged commit a555a27 into dogechain-lab:dev Nov 24, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Nov 24, 2022
@0xcb9ff9 0xcb9ff9 deleted the fix/blockchain_metric_name branch November 24, 2022 03:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@DarianShawn DarianShawn DarianShawn approved these changes

@abrahamcruise321 abrahamcruise321 Awaiting requested review from abrahamcruise321 abrahamcruise321 is a code owner

Assignees

@0xcb9ff9 0xcb9ff9

Labels
bug fix Functionality that fixes a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@0xcb9ff9 @DarianShawn