Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[crypto] Keccak256 method add sync.Pool #279

Merged
merged 2 commits into from
Jan 10, 2023
Merged

[crypto] Keccak256 method add sync.Pool #279

merged 2 commits into from
Jan 10, 2023

Conversation

0xcb9ff9
Copy link

Description

Keccak256 method add sync.Pool, reduce memory allocation, and reduce GC pressure

Changes include

  • Bugfix (non-breaking change that solves an issue)

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels

Testing

  • I have tested this code with the official test suite

@0xcb9ff9 0xcb9ff9 added the bug fix Functionality that fixes a bug label Jan 10, 2023
@0xcb9ff9 0xcb9ff9 self-assigned this Jan 10, 2023
@0xcb9ff9 0xcb9ff9 changed the title [crypto] Keccak256 method use sync.Pool [crypto] Keccak256 method add sync.Pool Jan 10, 2023
DarianShawn
DarianShawn approved these changes Jan 10, 2023
View reviewed changes
Copy link
Collaborator

@DarianShawn DarianShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DarianShawn DarianShawn merged commit 9d37be7 into dogechain-lab:dev Jan 10, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jan 10, 2023
@0xcb9ff9 0xcb9ff9 deleted the fix/keccak-api-call branch January 10, 2023 09:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@DarianShawn DarianShawn DarianShawn approved these changes

@abrahamcruise321 abrahamcruise321 Awaiting requested review from abrahamcruise321 abrahamcruise321 is a code owner

Assignees

@0xcb9ff9 0xcb9ff9

Labels
bug fix Functionality that fixes a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@0xcb9ff9 @DarianShawn