Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update snapshot after processBlock ends #30

Merged
merged 2 commits into from
May 10, 2022

Conversation

DarianShawn
Copy link
Collaborator

Description

This PR delays the call to processHeaders() until after the block has been verified and processed completely.

Previously, snapshot updating was done during verifyHeaders() despite processBlock() potentially failing afterwards.

This PR is merging from Polygon-Edge PR 482

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

Manual tests

Tested manually with a 4-node cluster. Steps:

  1. Spin up 4 nodes (develop build)
  2. Sequentially restart all nodes (fix/snapshot_update build)
  3. Nothing breaks

@DarianShawn DarianShawn added the bug fix Functionality that fixes a bug label May 5, 2022
@DarianShawn DarianShawn self-assigned this May 5, 2022
Copy link
Collaborator

@abrahamcruise321 abrahamcruise321 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@abrahamcruise321 abrahamcruise321 merged commit 4e53007 into dev May 10, 2022
@abrahamcruise321 abrahamcruise321 deleted the fix/update-snapshot-after-processBlock branch May 10, 2022 02:19
@github-actions github-actions bot locked and limited conversation to collaborators May 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug fix Functionality that fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants