-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feature] support jaeger telemetry #317
Conversation
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## dev #317 +/- ##
==========================================
- Coverage 47.74% 47.49% -0.25%
==========================================
Files 132 135 +3
Lines 20125 20431 +306
==========================================
+ Hits 9608 9704 +96
- Misses 9684 9892 +208
- Partials 833 835 +2
... and 5 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I love this great idea with bringing an open tracer standard into project to make tracking clearer.
Some more suggestions here though:
- Use the same context as much as possible.
- To exactly unveil our complex calling hierarchy.
- Use server option mode for more and more flags?
- To better tidy and expand our feature flags.
- Don't do it in current PR any way.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Logs are difficult to track complex logic, e.g. connection management.
This PR uses Jaeger to provides a basic debugging environment.
Add flag:
jaeger
enable the jaeger telemetryjaeger-address
jaeger thrift protocol endpointChanges include
Checklist
Testing
Manual tests
dogechain
node, but addjaeger
flag--jaeger
--jaeger-address "http://127.0.0.1:14268/api/traces"
example:
dogechain server --chain ./genesis.json --jaeger --jaeger-address "http://127.0.0.1:14268/api/traces"