Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] support jaeger telemetry #317

Merged
merged 9 commits into from
Mar 24, 2023

Conversation

0xcb9ff9
Copy link

@0xcb9ff9 0xcb9ff9 commented Mar 8, 2023

Description

Logs are difficult to track complex logic, e.g. connection management.
This PR uses Jaeger to provides a basic debugging environment.

Add flag:

  • jaeger enable the jaeger telemetry
  • jaeger-address jaeger thrift protocol endpoint

Changes include

  • New feature (non-breaking change that adds functionality)

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

Manual tests

  1. Install local jaeger server docs
  2. Run dogechain node, but add jaeger flag --jaeger --jaeger-address "http://127.0.0.1:14268/api/traces"
    example: dogechain server --chain ./genesis.json --jaeger --jaeger-address "http://127.0.0.1:14268/api/traces"

@0xcb9ff9 0xcb9ff9 added the feature New update to Dogechain label Mar 8, 2023
@0xcb9ff9 0xcb9ff9 requested a review from DarianShawn as a code owner March 8, 2023 03:31
@0xcb9ff9 0xcb9ff9 self-assigned this Mar 8, 2023
@0xcb9ff9 0xcb9ff9 changed the title [feature] support jaeger telemetry method call [feature] support jaeger telemetry Mar 8, 2023
@codecov-commenter
Copy link

codecov-commenter commented Mar 8, 2023

Codecov Report

Merging #317 (c783e29) into dev (d7c5a9e) will decrease coverage by 0.25%.
The diff coverage is 63.17%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##              dev     #317      +/-   ##
==========================================
- Coverage   47.74%   47.49%   -0.25%     
==========================================
  Files         132      135       +3     
  Lines       20125    20431     +306     
==========================================
+ Hits         9608     9704      +96     
- Misses       9684     9892     +208     
- Partials      833      835       +2     
Impacted Files Coverage Δ
jsonrpc/jsonrpc.go 25.00% <ø> (ø)
network/discovery/discovery.go 26.53% <0.00%> (-1.22%) ⬇️
network/identity/identity.go 21.60% <0.00%> (-3.95%) ⬇️
helper/common/common.go 8.72% <46.42%> (ø)
network/peer_connect.go 73.80% <73.80%> (ø)
network/keep_available.go 69.86% <81.81%> (+1.05%) ⬆️
network/server.go 71.78% <81.81%> (-0.20%) ⬇️
network/e2e_testing.go 66.66% <100.00%> (+0.22%) ⬆️
network/server_discovery.go 73.94% <100.00%> (+0.75%) ⬆️
network/server_identity.go 91.39% <100.00%> (+0.70%) ⬆️
... and 1 more

... and 5 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Collaborator

@DarianShawn DarianShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love this great idea with bringing an open tracer standard into project to make tracking clearer.

Some more suggestions here though:

  • Use the same context as much as possible.
    • To exactly unveil our complex calling hierarchy.
  • Use server option mode for more and more flags?
    • To better tidy and expand our feature flags.
    • Don't do it in current PR any way.

command/helper/helper.go Outdated Show resolved Hide resolved
helper/telemetry/type_convert.go Show resolved Hide resolved
network/server.go Show resolved Hide resolved
network/peer_connect.go Show resolved Hide resolved
network/server.go Show resolved Hide resolved
@0xcb9ff9 0xcb9ff9 mentioned this pull request Mar 21, 2023
4 tasks
Copy link
Collaborator

@DarianShawn DarianShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DarianShawn DarianShawn merged commit c23260d into dogechain-lab:dev Mar 24, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Mar 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature New update to Dogechain
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants