Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade go 1.19 #318

Merged
merged 3 commits into from
Apr 11, 2023
Merged

upgrade go 1.19 #318

merged 3 commits into from
Apr 11, 2023

Conversation

0xcb9ff9
Copy link

@0xcb9ff9 0xcb9ff9 commented Mar 9, 2023

Description

go 1.17/1.18 now is EOL, need update go version

Change

  • move columnize library to internal library (columnize library has been unmaintained for a long time, we need to maintain it)

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels

Testing

  • I have tested this code with the official test suite

@0xcb9ff9 0xcb9ff9 added the dependencies Update to the dependencies label Mar 9, 2023
@0xcb9ff9 0xcb9ff9 added this to the Release 1.4.0 milestone Mar 9, 2023
@0xcb9ff9 0xcb9ff9 requested a review from DarianShawn as a code owner March 9, 2023 07:43
@0xcb9ff9 0xcb9ff9 self-assigned this Mar 9, 2023
@codecov-commenter
Copy link

codecov-commenter commented Mar 9, 2023

Codecov Report

Merging #318 (5bbc35c) into dev (7520391) will increase coverage by 0.38%.
The diff coverage is 100.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##              dev     #318      +/-   ##
==========================================
+ Coverage   47.27%   47.65%   +0.38%     
==========================================
  Files         135      136       +1     
  Lines       20475    20603     +128     
==========================================
+ Hits         9679     9819     +140     
+ Misses       9965     9955      -10     
+ Partials      831      829       -2     
Impacted Files Coverage Δ
helper/columnize/columnize.go 100.00% <100.00%> (ø)

... and 3 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

DarianShawn
DarianShawn previously approved these changes Mar 9, 2023
Copy link
Collaborator

@DarianShawn DarianShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
More tests are needed.
Anyway, we have to bump a new version for this.

@0xcb9ff9 0xcb9ff9 changed the title [WIP] upgrade go 1.19 upgrade go 1.19 Apr 10, 2023
Copy link
Collaborator

@DarianShawn DarianShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@0xcb9ff9 0xcb9ff9 merged commit c202b4e into dogechain-lab:dev Apr 11, 2023
@0xcb9ff9 0xcb9ff9 deleted the update/go-1.19 branch April 11, 2023 05:37
@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dependencies Update to the dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants