Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix V-DOGE-VUL-010 #49

Merged
merged 2 commits into from
May 19, 2022
Merged

fix V-DOGE-VUL-010 #49

merged 2 commits into from
May 19, 2022

Conversation

abrahamcruise321
Copy link
Collaborator

Description

MustDecodeHex(input) could cause process panic. input content come from outer. main process should not panic handle the msg came from outer. Throw the error and log the info in stead of panic.

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

@abrahamcruise321 abrahamcruise321 added the bug fix Functionality that fixes a bug label May 17, 2022
@abrahamcruise321 abrahamcruise321 self-assigned this May 17, 2022
@abrahamcruise321 abrahamcruise321 linked an issue May 17, 2022 that may be closed by this pull request
Fix V-DOGE-VUL-010 #48
Closed
DarianShawn
DarianShawn reviewed May 17, 2022
View reviewed changes
helper/hex/hex.go Outdated Show resolved Hide resolved
DarianShawn
DarianShawn reviewed May 17, 2022
View reviewed changes
Copy link
Collaborator

@DarianShawn DarianShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work, 🙌
We only need a little typo work.

DarianShawn
DarianShawn approved these changes May 19, 2022
View reviewed changes
Copy link
Collaborator

@DarianShawn DarianShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 💯

@DarianShawn DarianShawn merged commit 89a6991 into dev May 19, 2022
@DarianShawn DarianShawn deleted the 48-fix-v-doge-vul-010 branch May 19, 2022 03:15
@github-actions github-actions bot locked and limited conversation to collaborators May 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@DarianShawn DarianShawn DarianShawn approved these changes

Assignees

@abrahamcruise321 abrahamcruise321

Labels
bug fix Functionality that fixes a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix V-DOGE-VUL-010
2 participants
@abrahamcruise321 @DarianShawn