Reorder the db WriteBlock codes to reduce the harm of partial-write #52
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The PR fixes a fatal problem when block is partial written to the db.
When a node is Writing block, the state was written after
WriteHeader
, once the node restart just afterWriteHeader
, the node would definitely failed to sync from other nodes any more.The only way to recover by now, is to remove all blockchain data, and restart syncing from the Genesis block.
Because the node take if for granted that it has the the current header's state saved, though it is not. When syncing blocks, it would failed due to state not found.
The best way would be using batch written implementation like
go-ethereum
, which provides some transaction-like mechanism. It should be another big PR though.Changes include
Checklist
Testing
Manual tests