Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove contractAddress from receipt if not contract deployment #60

Merged
merged 2 commits into from
May 23, 2022
Merged

Remove contractAddress from receipt if not contract deployment #60

merged 2 commits into from
May 23, 2022

Conversation

DarianShawn
Copy link
Collaborator

Description

Native tx and calling contract methods should not have ContractAddress field set to 0x0 address.

This PR set it to null.

Merging from Polygon Edge PR 546

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Breaking changes

The older version client could not Unmarshal this new version client receipt.

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

@DarianShawn DarianShawn added hotfix Major bug fix that should be merged ASAP breaking change Breaking change feature labels May 23, 2022
@DarianShawn DarianShawn self-assigned this May 23, 2022
abrahamcruise321
abrahamcruise321 approved these changes May 23, 2022
View reviewed changes
Copy link
Collaborator

@abrahamcruise321 abrahamcruise321 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@abrahamcruise321 abrahamcruise321 merged commit 08020e1 into dev May 23, 2022
@abrahamcruise321 abrahamcruise321 deleted the fix/native-transfers-should-not-have-contract-address branch May 23, 2022 09:22
@github-actions github-actions bot locked and limited conversation to collaborators May 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@abrahamcruise321 abrahamcruise321 abrahamcruise321 approved these changes

Assignees

@DarianShawn DarianShawn

Labels
breaking change Breaking change feature hotfix Major bug fix that should be merged ASAP
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DarianShawn @abrahamcruise321