Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reverse vault api v1.5.0 back to v1.3.1 #63

Merged
merged 1 commit into from
May 23, 2022
Merged

reverse vault api v1.5.0 back to v1.3.1 #63

merged 1 commit into from
May 23, 2022

Conversation

abrahamcruise321
Copy link
Collaborator

Description

reverse vault api v1.5.0 back to v1.3.1

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

@abrahamcruise321 abrahamcruise321 linked an issue May 23, 2022 that may be closed by this pull request
reverse vault api v1.5.0 back to v1.3.1 #62
Closed
@abrahamcruise321 abrahamcruise321 self-assigned this May 23, 2022
@abrahamcruise321 abrahamcruise321 added the bug fix Functionality that fixes a bug label May 23, 2022
DarianShawn
DarianShawn approved these changes May 23, 2022
View reviewed changes
Copy link
Collaborator

@DarianShawn DarianShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌 So that's the reason why GitHub action always failed on lint and test.
LGTM.

@DarianShawn DarianShawn merged commit 6236dd3 into dev May 23, 2022
@DarianShawn DarianShawn deleted the 62-reverse-vault-api-v150-back-to-v131 branch May 23, 2022 16:51
@github-actions github-actions bot locked and limited conversation to collaborators May 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@DarianShawn DarianShawn DarianShawn approved these changes

Assignees

@abrahamcruise321 abrahamcruise321

Labels
bug fix Functionality that fixes a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

reverse vault api v1.5.0 back to v1.3.1
2 participants
@abrahamcruise321 @DarianShawn