Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: New pre-deploy contracts #9

Merged
merged 18 commits into from
Apr 21, 2022
Merged

Conversation

DarianShawn
Copy link
Collaborator

Description

  1. This PR import two new pre-deploy contracts, Bridge and Vault.
    Bridge contract is used for dogecoin blockchain crossing.
    Vault contract is used for system reward collection and community profit sharing (T.B.D.).

  2. Add an owner to Staking contract, who in charge of validator authorizations.
    The owner would return rights to the community in the near future.

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Breaking changes

Different genesis means re-deployment of network or hard fork. Re-deploy network would be a better choice for now.

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

Manual tests

  1. Set up a local network of 4 nodes, which uses a Genesis sharing the same owner of all system contracts.
  2. Try deposit, withdraw token from Bridge contract.
  3. Check out the ValidatorSet on Staking contract.
  4. Add and remove validator, using the owner authorization.

@DarianShawn DarianShawn added the feature New update to Dogechain label Apr 21, 2022
@DarianShawn DarianShawn self-assigned this Apr 21, 2022
@DarianShawn DarianShawn linked an issue Apr 21, 2022 that may be closed by this pull request
@DarianShawn DarianShawn changed the title Feature/new predeploy contracts WIP: Feature/new predeploy contracts Apr 21, 2022
@DarianShawn DarianShawn changed the title WIP: Feature/new predeploy contracts WIP: New pre-deploy contracts Apr 21, 2022
@DarianShawn DarianShawn added the investigating This behavior is still being tested out label Apr 21, 2022
Copy link
Collaborator

@abrahamcruise321 abrahamcruise321 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@abrahamcruise321 abrahamcruise321 merged commit 889e930 into dev Apr 21, 2022
@abrahamcruise321 abrahamcruise321 deleted the feature/new-predeploy-contracts branch April 21, 2022 08:14
@github-actions github-actions bot locked and limited conversation to collaborators Apr 21, 2022
@DarianShawn DarianShawn removed the investigating This behavior is still being tested out label Apr 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature New update to Dogechain
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add already done features to new Jury projects
2 participants