Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sbin install dir configurable #1028

Merged
merged 2 commits into from
Jan 17, 2025
Merged

Make sbin install dir configurable #1028

merged 2 commits into from
Jan 17, 2025

Conversation

fmarco76
Copy link
Member

@fmarco76 fmarco76 requested a review from edewata January 17, 2025 14:35
@fmarco76 fmarco76 marked this pull request as draft January 17, 2025 14:46
@fmarco76 fmarco76 marked this pull request as ready for review January 17, 2025 15:09
@fmarco76
Fix dnf localinstall
f6f3347 
dnf5 drops support `localinstall` but just `install`.
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@fmarco76
Copy link
Member Author

There are few failure but they are not related

edewata
edewata approved these changes Jan 17, 2025
View reviewed changes
Copy link
Contributor

@edewata edewata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fmarco76
Copy link
Member Author

@edewata Thanks!

@fmarco76 fmarco76 merged commit 8d9c397 into dogtagpki:master Jan 17, 2025
31 of 36 checks passed
@fmarco76 fmarco76 deleted the sbinMerge branch January 17, 2025 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edewata edewata edewata approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fmarco76 @edewata