Support favoring other Cryptographic Providers #240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We're previously given the option to either install the JSS provider or not, and optionally to remove the Sun Provider. Users can re-order the providers later if they want, but the most common other option will be to only use JSS for specified operations. To achieve this, we put JSS as the very last provider. Hence, add: installJSSProviderFirst = true as a new value in InitializationValues. Signed-off-by: Alexander Scheel <ascheel@redhat.com>
cipherboy
added
enhancement
|
As discussed on IRC, the patch works, but maybe the ideal solution is to modify everything that requires JSS to explicitly use JSS provider so that the order of system providers does not matter. |
|
Well, I think this is a good PR to have from an upstream provider, I agree that we can explicitly call into JSS in TomcatJSS / PKI if we want to. But the real PR that we want to have in JSS is to use the system trust store. That is what will really fix your issue I think. Edit: So I'm in favor of merging this. |
|
Pending a system trust store sensitive TrustManager, I'm going to go ahead and merge this as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're previously given the option to either install the JSS provider or
not, and optionally to remove the Sun Provider. Users can re-order the
providers later if they want, but the most common other option will be
to only use JSS for specified operations. To achieve this, we put JSS as
the very last provider. Hence, add:
as a new value in InitializationValues.
Signed-off-by: Alexander Scheel <ascheel@redhat.com>