Restore default value for pki_share_db #4533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In commit 22a1b3d the default values for pki_share_db for non-CA subsystems were changed to False since subsystems on separate instances will not share the same database user, but apparently it causes a problem during TPS installation with a shared instance. To avoid changing the behavior, the default values have been restored to True. This param can still be overridden in pkispawn config as needed. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=2228209
|
Kudos, SonarCloud Quality Gate passed! |
|
@ladycfu Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In commit 22a1b3d the default values for
pki_share_dbfor non-CA subsystems were changed toFalsesince subsystems on separate instances will not share the same database user, but apparently it causes a problem during TPS installation with a shared instance.To avoid changing the behavior, the default values have been restored to
True. This param can still be overridden inpkispawnconfig as needed.Note: There's a separate issue that causes token enrollment to fail, but the shared secret creation should work correctly now.
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=2228209