Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to v2 APIs #4837

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Move to v2 APIs #4837

wants to merge 1 commit into from

Conversation

fmarco76
Copy link
Member

With this PR the default API (with /rest path) will be v2 and all the pki CLI will use this version.

Current API are still available but the path will be /<pki_subsystem>/v1/<path>.
In order to revert default to v1 it is possible to modify the file /usr/share/pki/server/conf/Catalina/localhost/rewrite.config linked from all the instances or the file link /etc/pki/<pki-instance>/Catalina/localhost/rewrite.config for a single instance.

@fmarco76 fmarco76 requested a review from edewata August 27, 2024 16:15
@fmarco76
Copy link
Member Author

@rcritten @flo-renaud after we merge this PR, IPA should modify the file as in the description, or the httpd proxy configuration, to continue with current API, which will be available until you have switched to the new API.
Currently they implement the same endpoint but they support only JSON format.

Copy link
Contributor

@edewata edewata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fmarco76 The changes look fine, but does it mean that IPA tests (in PKI CI and IPA CI) will fail until IPA is updated to use /v1 instead of /rest? Or should IPA be updated first before merging this PR?

@fmarco76
Copy link
Member Author

@fmarco76 The changes look fine, but does it mean that IPA tests (in PKI CI and IPA CI) will fail until IPA is updated to use /v1 instead of /rest? Or should IPA be updated first before merging this PR?

Yes, we have to wait IPA to modify the deploy in order to continue using the current API version.

Copy link

sonarcloud bot commented Sep 18, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants