Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create dog and dog/run packages #113

Merged
merged 13 commits into from
Jan 30, 2017
Merged

Create dog and dog/run packages #113

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
e2c4f09
Create dog and dog/run packages
xsb Jan 19, 2017
b338de0
Add example exposing tasks through HTTP
xsb Jan 19, 2017
bd0ec8d
CombinedOutput returns an io.Reader
divan Jan 20, 2017
e4a3f59
Format error using fmt.Errorf
xsb Jan 22, 2017
36b1976
Add error handling to ListenAndServe
xsb Jan 22, 2017
efcfb59
Typo
xsb Jan 22, 2017
ead3340
Remove unnecessary string concatenation
xsb Jan 22, 2017
553a6ae
Revert "Remove unnecessary string concatenation"
xsb Jan 22, 2017
e06469c
Fix unnecessary concatenation, improve code comment.
xsb Jan 22, 2017
e1d5362
Add fail if task does not exist at package level
xsb Jan 22, 2017
4446f4c
No need to declare timeMsg variable
xsb Jan 23, 2017
5cb24e3
Run accepts two io.Writers to collect stdout and stderr separately
xsb Jan 30, 2017
812f202
Update examples, now passing stdout and stderr to Run()
xsb Jan 30, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 5 additions & 6 deletions chain.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,21 +134,20 @@ func (taskChain *TaskChain) Run() error {
}

// formatDuration is a time formatter.
func formatDuration(d time.Duration) (s string) {
timeMsg := ""
func formatDuration(d time.Duration) (timeMsg string) {

if d.Hours() > 1.0 {
timeMsg += fmt.Sprintf("%1.0fh", d.Hours())
timeMsg = fmt.Sprintf("%1.0fh", d.Hours())
}

if d.Minutes() > 1.0 {
timeMsg += fmt.Sprintf("%1.0fm", d.Minutes())
timeMsg = fmt.Sprintf("%1.0fm", d.Minutes())
}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Concatenation was unnecessary only for hours. Because initially we had blank string. Now we always rewrite string variable which may not be the intention. Sorry for confusing you with unclear comment.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True! This code was written half a year ago and I forgot how it worked. I added a better comment explaining the format.


if d.Seconds() > 1.0 {
timeMsg += fmt.Sprintf("%1.0fs", d.Seconds())
timeMsg = fmt.Sprintf("%1.0fs", d.Seconds())
} else {
timeMsg += fmt.Sprintf("%1.3fs", d.Seconds())
timeMsg = fmt.Sprintf("%1.3fs", d.Seconds())
}

return timeMsg
Expand Down