URL can be given for a repo

dogweather · Dec 26, 2015 · 895b6c7 · 895b6c7
1 parent ab14908
commit 895b6c7
Show file tree

Hide file tree

Showing 6 changed files with 52 additions and 11 deletions.
diff --git a/lib/github.js b/lib/github.js
diff --git a/lib/repo.js b/lib/repo.js
diff --git a/lib/spec/test.js b/lib/spec/test.js
diff --git a/src/github.coffee b/src/github.coffee
@@ -1,9 +1,24 @@
 # Utility functions for working with the GitHub API
 class App.Github
 
+  @parseRepoInput: (text) ->
+    if @isRepoSpec(text)
+      text.split('/')
+    else if @isUrl(text)
+      matches = text.match(/^https:\/\/github.com\/([^/]+)\/([^/]+)/)
+      [matches[1], matches[2]]
+    else
+      null
+
+
   @isUrl: (text) ->
     /^https:\/\/github.com\/[^/]+\/[^/]+/.test(text)
 
+
+  @isRepoSpec: (text) ->
+    /^[^/]+\/[^/]+$/.test(text)
+
+
   @rateLimit: (callback) ->
     App.octo.rateLimit.fetch (err, data) ->
       if err

diff --git a/src/repo.coffee b/src/repo.coffee
@@ -1,7 +1,8 @@
 class App.Repo
-  # @param repo_spec should be a string like "facebook/react"
+  # @param repo_spec should be a string like "facebook/react" or a GitHub
+  # project URL.
   constructor: (repo_spec, @repoCallback, @issuesCallback, network = true) ->
-    [@acct, @name] = repo_spec.split('/')
+    [@acct, @name] = App.Github.parseRepoInput(repo_spec)
     @rawdata = {}
     @fetchData() if network
 

diff --git a/test/spec/test.coffee b/test/spec/test.coffee
@@ -126,24 +126,28 @@ describe "App.Github", ->
 
   describe ".isRepoSpec()", ->
 
-    xit "recognizes a valid spec", ->
+    it "recognizes a valid spec", ->
       validSpec = 'dogweather/repo-health-check'
       expect( App.Github.isRepoSpec(validSpec) ).toBe true
 
-    xit "rejects a string with two /'s", ->
+    it "rejects a string with two /'s", ->
       inValidSpec = '/dogweather/repo-health-check'
       expect( App.Github.isRepoSpec(inValidSpec) ).toBe false
 
   describe ".parseRepoInput()", ->
 
-    xit "parses a project URL", ->
+    it "parses a project URL", ->
       validUrl = 'https://github.com/dogweather/repo-health-check'
       [acct, name] = App.Github.parseRepoInput(validUrl)
       expect( acct ).toEqual 'dogweather'
       expect( name ).toEqual 'repo-health-check'
 
-    xit "parses a repo spec", ->
+    it "parses a repo spec", ->
       validSpec = 'dogweather/repo-health-check'
       [acct, name] = App.Github.parseRepoInput(validSpec)
       expect( acct ).toEqual 'dogweather'
       expect( name ).toEqual 'repo-health-check'
+
+    it "returns null if input is neither a URL or repo spec", ->
+      inValidSpec = '/dogweather/repo-health-check'
+      expect( App.Github.parseRepoInput(inValidSpec) ).toBe null