Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: #684 type error property push does not exist on type #774

Merged
merged 2 commits into from
Feb 9, 2025

Conversation

mamos-mysten
Copy link
Contributor

Fixes #684

Description

Applied the patch mentioned in #684 (comment) so that dependent projects can stop relying on patches.

Review

  • I self-reviewed this PR

Testing

  • I added/updated tests
  • I manually tested

Copy link

changeset-bot bot commented Jan 31, 2025

⚠️ No Changeset found

Latest commit: a1ec915

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Jan 31, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-native-reanimated-carousel ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 9, 2025 4:41pm

@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Jan 31, 2025
Copy link

codecov bot commented Feb 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.29%. Comparing base (4f0b917) to head (a1ec915).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #774      +/-   ##
==========================================
- Coverage   74.35%   74.29%   -0.07%     
==========================================
  Files          35       35              
  Lines         819      817       -2     
  Branches      237      237              
==========================================
- Hits          609      607       -2     
  Misses        145      145              
  Partials       65       65              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dohooo dohooo merged commit 602ce7b into dohooo:main Feb 9, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Property 'push' does not exist on type
2 participants